Skip to content

fix(skmo): look up RabbitMQ credentials via TransportURL and RabbitMQUser status#3956

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
lmiccini:fix-leaf-listener-secret-lookup
May 27, 2026
Merged

fix(skmo): look up RabbitMQ credentials via TransportURL and RabbitMQUser status#3956
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
lmiccini:fix-leaf-listener-secret-lookup

Conversation

@lmiccini
Copy link
Copy Markdown
Contributor

@lmiccini lmiccini commented May 23, 2026

Instead of hardcoding the secret name pattern, resolve the credentials secret dynamically: TransportURL -> RabbitMQUser CR -> status.secretName. This works with both legacy and canonical (hash-based, see openstack-k8s-operators/infra-operator#583) RabbitMQ user naming schemes.

@lmiccini lmiccini requested a review from vakwetu May 23, 2026 05:44
…User status

Instead of hardcoding the secret name pattern, resolve the credentials
secret dynamically: TransportURL -> RabbitMQUser CR -> status.secretName.
This works with both legacy and canonical (hash-based) RabbitMQ user
naming schemes.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Signed-off-by: Luca Miccini <lmiccini@redhat.com>
@lmiccini lmiccini force-pushed the fix-leaf-listener-secret-lookup branch from 83f3619 to 4d889fa Compare May 23, 2026 05:46
Copy link
Copy Markdown
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Copy Markdown
Contributor

@vakwetu vakwetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. I had actually put together something similar last week, but forgot to submit it!

Copy link
Copy Markdown
Contributor

@rebtoor rebtoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rebtoor
Copy link
Copy Markdown
Contributor

rebtoor commented May 27, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 27, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 1636490 into openstack-k8s-operators:main May 27, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants